| commit | a327923d4ba7b47b8ff07fe42ccb025fd9c894b9 | [log] [tgz] |
|---|---|---|
| author | Chris Sides <christopher.sides@hpe.com> | Mon Apr 24 16:08:13 2023 -0500 |
| committer | Christopher Sides <christopher.sides@hpe.com> | Thu Mar 21 20:09:01 2024 +0000 |
| tree | 64cf2a2c4f1b88549a038c48ec93a443861c5f78 | |
| parent | b2a0f2e0bfb5bc28fce737339f67df6a842cb726 [diff] |
add hysteresis param to parseThresholdsFromAttr() Parameter 'hysteresis' with a default = NaN, is added to the header for parseThresholdsFromAttr(), and existing calls to it now explicitly specify a hysteresis value. This is an alternative to having calls to parseThresholdFromAttr() use a hardcoded Intel-specific value of '0.' The 'NaN' value was chosen as default because it reflects the value that was being written before a device-specific value was hardcoded in to solve a specific issue. Change was created based on the discussion here: https://gerrit.openbmc.org/c/openbmc/dbus-sensors/+/61744/comments/38f6a 221_58a39817a Tested: Confirmed the code builds and doesn't throw errors with OBMC 'local CI' testing. I believe heavier testing with actual Intel HW isn't needed because this change simple moves where a value is specified (from hardcode in function body to passed-in parameter) without affecting any existing in-use functionality. Change-Id: I1240b951d6e37adc1aad5ad3b19144f6baa64998 Signed-off-by: Chris Sides <christopher.sides@hpe.com>
dbus-sensors is a collection of sensor applications that provide the xyz.openbmc_project.Sensor collection of interfaces. They read sensor values from hwmon, d-bus, or direct driver access to provide readings. Some advance non-sensor features such as fan presence, pwm control, and automatic cpu detection (x86) are also supported.
runtime re-configurable from d-bus (entity-manager or the like)
isolated: each sensor type is isolated into its own daemon, so a bug in one sensor is unlikely to affect another, and single sensor modifications are possible
async single-threaded: uses sdbusplus/asio bindings
multiple data inputs: hwmon, d-bus, direct driver access
A typical dbus-sensors object support the following dbus interfaces:
Path /xyz/openbmc_project/sensors/<type>/<sensor_name>
Interfaces xyz.openbmc_project.Sensor.Value
xyz.openbmc_project.Sensor.Threshold.Critical
xyz.openbmc_project.Sensor.Threshold.Warning
xyz.openbmc_project.State.Decorator.Availability
xyz.openbmc_project.State.Decorator.OperationalStatus
xyz.openbmc_project.Association.Definitions
Sensor interfaces collection are described here.
Consumer examples of these interfaces are Redfish, Phosphor-Pid-Control, IPMI SDR.
dbus-sensor daemons are reactors that dynamically create and update sensors configuration when system configuration gets updated.
Using asio timers and async calls, dbus-sensor daemons read sensor values and check thresholds periodically. PropertiesChanged signals will be broadcasted for other services to consume when value or threshold status change. OperationStatus is set to false if the sensor is determined to be faulty.
A simple sensor example can be found here.
Sensor devices are described using Exposes records in configuration file. Name and Type fields are required. Different sensor types have different fields. Refer to entity manager schema for complete list.
ADC sensors are sensors based on an Analog to Digital Converter. They are read via the Linux kernel Industrial I/O subsystem (IIO).
One of the more common use cases within OpenBMC is for reading these sensors from the ADC on the Aspeed ASTXX cards.
To utilize ADC sensors feature within OpenBMC you must first define and enable it within the kernel device tree.
When using a common OpenBMC device like the AST2600 you will find a "adc0" and "adc1" section in the aspeed-g6.dtsi file. These are disabled by default so in your system-specific dts you would enable and configure what you want with something like this:
iio-hwmon {
compatible = "iio-hwmon";
io-channels = <&adc0 0>;
...
}
&adc0 {
status = "okay";
...
};
&adc1 {
status = "okay";
...
};
Note that this is not meant to be an exhaustive list on the nuances of configuring a device tree but really to point users in the general direction.
You will then create an entity-manager configuration file that is of type "ADC" A very simple example would like look this:
"Index": 0,
"Name": "P12V",
"PowerState": "Always",
"ScaleFactor": 1.0,
"Type": "ADC"
When your system is booted, a "in0_input" file will be created within the hwmon subsystem (/sys/class/hwmon/hwmonX). The adcsensor application will scan d-bus for any ADC entity-manager objects, look up their "Index" value, and try to match that with the hwmon inY_input files. When it finds a match it will create a d-bus sensor under the xyz.openbmc_project.ADCSensor service. The sensor will be periodically updated based on readings from the hwmon file.