commit | 834c078612909710beef2f65802237e7c659983f | [log] [tgz] |
---|---|---|
author | Priyanga Ramasamy <priyanga24@in.ibm.com> | Tue Feb 14 12:22:39 2023 -0600 |
committer | priyanga24 <priyanga24@in.ibm.com> | Wed Mar 01 03:35:06 2023 +0000 |
tree | b54604852b871919354e8d7d7df1a6586969de96 | |
parent | 6555e7efc40c305e5c3c8863c3d1793f474ec7e2 [diff] |
Defect fix in restoring system VPD via vpd-manager In vpd-manager restore api, the keyword defaults should be taken from the system vpd map. Instead it assumes blank value as default for all keywords. This fails to restore UTIL D0 keyword as its default value is 0x00. This commit fixes the issue. Test: ~#vpd-tool -w -H -O /sys/bus/i2c/drivers/at24/8-0050/eeprom -R UTIL -K D0 -V 0x00 ~# vpd-tool --fixSystemVPD =============================================================================================================================================================================================== S.No Record Keyword Data On BMC Data On System Backplane Data Mismatch =============================================================================================================================================================================================== 1 UTIL D0 0x01 0x00 YES ~#busctl set-property xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system/chassis/motherboard xyz.openbmc_project.Inventory.Item Present b false ~#systemctl restart system-vpd.service ~#vpd-tool --fixSystemVPD =============================================================================================================================================================================================== S.No Record Keyword Data On BMC Data On System Backplane Data Mismatch =============================================================================================================================================================================================== 1 UTIL D0 0x01 0x01 NO Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com> Change-Id: If6817829211e9b8a47652deab5d1ec7643855fb6
This repository hosts code for OpenPower and IBM IPZ format VPD parsers. Both OpenPower VPD and IPZ VPD formats are structured binaries that consist of records and keywords. A record is a collection of multiple keywords. More information about the format can be found here.
The repository consists of two distinct applications, which are:
This is a build-time YAML driven application that parses the OpenPower VPD format and uses the YAML configuration (see extra-properties-example.yaml and writefru.yaml) to determine:
The application instance must be passed in the file path to the VPD (this can, for example, be a sysfs path exposed by the EEPROM device driver) and also the D-Bus object path(s) that EEPROM data needs to be published under.
This parser is can be built by passing in the --enable-ibm-parser
configure option. This parser differs from the OpenPower VPD parser in the following ways:
#
and are > 255 bytes in length).Making the application runtime JSON driven allows us to support multiple systems (with different FRU configurations) to be supported in a single code image as well as making the application more flexible for future improvements.