Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-net-ipmid / 46bec0f60a201a644c1f3af4cec2f31da58a0595
commit46bec0f60a201a644c1f3af4cec2f31da58a0595[log] [tgz]
authorJason M. Bills <jason.m.bills@linux.intel.com>Wed Dec 11 11:01:18 2019 -0800
committerJason Bills <jason.m.bills@linux.intel.com>Tue Dec 17 19:01:12 2019 +0000
tree4325312ecb76f4e3f9719d345f63d1e672514842
parent8e342c9c65c602b2fc85c80b8a75c5d515c48059 [diff]
Always return Message Tag and Remote Console Session ID

Per the IPMI spec, even on an error we should return the
Message Tag and Remote Console Session ID values.

This sets those two response values first so they are always
set in case of an error.

Tested:
Ran ipmitool with verbose enabled and confirmed that the
Console Session ID is set:
ipmitool -vv -C 7 mc info

<<OPEN SESSION RESPONSE
<<  Message tag                        : 0x00
<<  RMCP+ status                       : invalid authentication algorithm
<<  Maximum privilege level            : Unknown (0x00)
<<  Console Session ID                 : 0xa0a2a3a4

Ran ipmipower with --debug and confirmed that the Message Tag
is set and the command returns an error instead of timing out
ipmipower --debug -D LAN_2_0 -s -l ADMIN -I 7

IPMI Command Data:
------------------
[              BCh] = message_tag[ 8b]
[               4h] = rmcpplus_status_code[ 8b]
[        41F00603h] = remote_console_session_id[32b]

Ran both of the above commands using cipher suite 17 and they
both complete successfully.

Change-Id: Ic21ec910103a1befdf5e79f7b1afaf83dae63e9f
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>
1 file changed
tree: 4325312ecb76f4e3f9719d345f63d1e672514842
  1. command/
  2. sol/
  3. test/
  4. .clang-format
  5. .gitignore
  6. auth_algo.cpp
  7. auth_algo.hpp
  8. bootstrap.sh
  9. comm_module.cpp
  10. comm_module.hpp
  11. command_table.cpp
  12. command_table.hpp
  13. configure.ac
  14. crypt_algo.cpp
  15. crypt_algo.hpp
  16. endian.hpp
  17. integrity_algo.cpp
  18. integrity_algo.hpp
  19. LICENSE
  20. main.cpp
  21. main.hpp
  22. MAINTAINERS
  23. Makefile.am
  24. message.hpp
  25. message_handler.cpp
  26. message_handler.hpp
  27. message_parsers.cpp
  28. message_parsers.hpp
  29. phosphor-ipmi-net@.service
  30. phosphor-ipmi-net@.socket
  31. prng.hpp
  32. README.md
  33. rmcp.hpp
  34. sd_event_loop.cpp
  35. sd_event_loop.hpp
  36. session.hpp
  37. sessions_manager.cpp
  38. sessions_manager.hpp
  39. socket_channel.hpp
  40. sol_module.cpp
  41. sol_module.hpp
README.md

To Build

To build this package, do the following steps:

    1. ./bootstrap.sh
    2. ./configure ${CONFIGURE_FLAGS}
    3. make

To clean the repository run `./bootstrap.sh clean`.