Gitiles
Code Review Sign In
gerrit.openbmc.org / openbmc / phosphor-psu-code-mgmt / d0f8bbb3fc1f18a3e33e55d29b1cc42e16758e91
commitd0f8bbb3fc1f18a3e33e55d29b1cc42e16758e91[log] [tgz]
authorLei YU <mine260309@gmail.com>Fri Oct 18 15:49:31 2019 +0800
committerLei YU <mine260309@gmail.com>Tue Nov 05 10:45:06 2019 +0800
tree6bc4265b14d2591bed7b277ca1e23b1ce3489b7d
parent2d15625237f1647504974f5b04010e7eccd4008b [diff]
Version: support CRLF line feed in MANIFEST

When a MANIFEST is generated from Windows and it contains CRLF as line
feed, the code was getting each line with '\r' at the end, and thus the
parsed string contains '\r' and it incorrectly parses the string.

Add a piece of code to support CRLF line feed so support such MANIFEST
files.

Tested: Added a unit test case to verify CRLF is correctly handled.

Signed-off-by: Lei YU <mine260309@gmail.com>
Change-Id: I99e146717b815e3e40c232376555b2b48d77bc56
2 files changed
tree: 6bc4265b14d2591bed7b277ca1e23b1ce3489b7d
  1. service/
  2. src/
  3. test/
  4. vendor-example/
  5. .clang-format
  6. .gitignore
  7. LICENSE
  8. MAINTAINERS
  9. meson.build
  10. meson_options.txt
  11. README.md
README.md

phosphor-psu-code-mgmt

phosphor-psu-code-mgmt is a service to provide management for PSU code, including:

  • PSU code version
  • PSU code update

Building

meson build/ && ninja -C build

Unit test

  • Run it in OpenBMC CI, refer to local-ci-build.md
  • Run it in OE SDK, run below commands in a x86-64 SDK env:
    meson -Doe-sdk=enabled -Dtests=enabled build/
ninja -C build/ test  # Meson skips running the case due to it thinks it's cross compiling
# Manually run the tests
for t in `find build/test/ -maxdepth 1 -name "test_*"`; do ./$t || break ; done