nbd-proxy: Don't discard subprocess stderr output
Previously we'd been redirecting the stderr of nbd-client and the
state-hook to /dev/null. While in the common case they're not needed,
when something does go wrong it's easier to debug things when their
error messages aren't swallowed whole, so let's leave stderr as whatever
file descriptor nbd-proxy inherits from its parent (which in the
expected scenario in OpenBMC should be bmcweb's stderr, which should end
up logged for easy visibility).
Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Change-Id: I0ae7e702ff2beb3023a356caef5fcb0a536e5a99
diff --git a/nbd-proxy.c b/nbd-proxy.c
index 54c8cf7..3928aac 100644
--- a/nbd-proxy.c
+++ b/nbd-proxy.c
@@ -150,7 +150,6 @@
dup2(fd, STDIN_FILENO);
dup2(fd, STDOUT_FILENO);
- dup2(fd, STDERR_FILENO);
close(fd);
execlp("nbd-client", "nbd-client",
@@ -406,7 +405,6 @@
dup2(fd, STDIN_FILENO);
dup2(fd, STDOUT_FILENO);
- dup2(fd, STDERR_FILENO);
execl(state_hook_path, argv0, action, ctx->config->name, NULL);
exit(EXIT_FAILURE);
}